chore: CRW-4043 update rhel.Dockerfile and... #67
Conversation
| # see also brew.Dockerfile | ||
|
|
||
| # https://registry.access.redhat.com/ubi8-minimal | ||
| FROM registry.access.redhat.com/ubi8-minimal:8.7-1049.1675784874 |
There was a problem hiding this comment.
I'm more in favor of using a go-toolset builder image (can be helpful for verifying Go version used for the build, etc) and then copying built artifacts into a basic ubi8-minimal image, but if that's how it's done here then so be it.
There was a problem hiding this comment.
These dockerfiles could probably be templated off something like https://github.com/devfile/devworkspace-operator/blob/main/build/Dockerfile
There was a problem hiding this comment.
https://github.com/devfile/devworkspace-operator/blob/main/build/Dockerfile is not cachito-compliant.
And I switched from using a two stage with go-toolset and then a ubi target to a single stage, as that's what we have been using downstream for some time. Could have gone the other way, but given rhel.Dockerfile isn't even being USED in the configbump build (because still using Alpine for some reason), figured that having upstream consistent with what's actually shipping downstream was better.
Would you be +1 to switch the configbump release process to use ubi8 instead of alpine, so we can stop having 3 ways to build it? if so we can handle that in eclipse-che/che#21988
There was a problem hiding this comment.
helpful for verifying Go version used for the build
The build log will show which RPMs / modules are installed:
golang-1.18.9-1.module+el8.7.0+17640+84246675.x86_64
golang-bin-1.18.9-1.module+el8.7.0+17640+84246675.x86_64
golang-src-1.18.9-1.module+el8.7.0+17640+84246675.noarch
which is in fact MORE detail than the container image tag, if you want to know that a CVE was patched in the build process.
There was a problem hiding this comment.
I'm +1 on removing alpine in general but it's not my decision to make -- I'm a bystander on this one.
As for the devworkspace operator Dockerfile -- the cachito-compliant version just replaces the builder COPY steps with
COPY $REMOTE_SOURCE $REMOTE_SOURCE_DIR
WORKDIR ${REMOTE_SOURCE_DIR}/app/The issue with Go version isn't that you don't know the exact version of Go, it's that Go can update minor versions freely, which can cause issues -- e.g. bumping to Go 1.17 to 1.18 will change your go.mod file.
… more closely aligned; update go.sum Change-Id: Iaccd3d8f1e2b68f3f85db08635abcedccbb59e54 Signed-off-by: Nick Boldt <nboldt@redhat.com>
|
Build 3.6 :: configbump_3.x/66: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2428: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1755: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1756: Console, Changes, Git Data |
|
Build 3.6 :: copyIIBsToQuay/983: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1755: Copied: configbump-rhel8; /job/DS_CI/job/update-digests_3.x triggered; |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2285: configbump : 3.x :: Build 50796304 : quay.io/devspaces/configbump-rhel8:3.6-4 |
|
Build 3.6 :: copyIIBsToQuay/984: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1756: Copied: configbump-rhel8; /job/DS_CI/job/update-digests_3.x triggered; |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2286: configbump : 3.x :: Build 50796526 : quay.io/devspaces/configbump-rhel8:3.6-5 |
|
Build 3.6 :: sync-to-downstream_3.x/2428: Build container: devspaces-configbump synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2286 triggered; |
|
Build 3.6 :: configbump_3.x/66: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2428 triggered |
|
Build 3.6 :: update-digests_3.x/2218: Console, Changes, Git Data |
|
Build 3.6 :: update-digests_3.x/2218: No new images detected: nothing to do! |
|
Build 3.6 :: update-digests_3.x/2219: Console, Changes, Git Data |
|
Build 3.6 :: update-digests_3.x/2219: No new images detected: nothing to do! |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2398: configbump : 3.x :: Failed in 50990579 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.6 :: configbump_3.x/69: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2597: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1876: Console, Changes, Git Data |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2470: configbump : 3.x :: Build 51098913 : quay.io/devspaces/configbump-rhel8:3.6-7 |
|
Build 3.6 :: configbump_3.x/69: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2597 triggered |
|
Build 3.6 :: update-digests_3.x/2370: Console, Changes, Git Data |
|
Build 3.6 :: copyIIBsToQuay/1106: Console, Changes, Git Data |
|
Build 3.6 :: operator-bundle_3.x/983: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2601: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1879: Console, Changes, Git Data |
|
Build 3.6 :: copyIIBsToQuay/1109: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2601: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2472 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.6 :: operator-bundle_3.x/983: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2601 triggered |
|
Build 3.6 :: update-digests_3.x/2370: Detected new images: rebuild operator-bundle |
|
Build 3.6 :: dsc_3.x/689: Console, Changes, Git Data |
|
Build 3.6 :: dsc_3.x/689: 3.6.0 CI |
|
Build 3.6 :: configbump_3.x/70: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2626: Console, Changes, Git Data |
|
Build 3.6 :: push-latest-container-to-quay_3.x/1897: Console, Changes, Git Data |
|
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2491: configbump : 3.x :: Build 51135810 : quay.io/devspaces/configbump-rhel8:3.6-8 |
|
Build 3.6 :: configbump_3.x/70: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2626 triggered |
|
Build 3.6 :: update-digests_3.x/2400: Console, Changes, Git Data |
|
Build 3.6 :: update-digests_3.x/2400: No new images detected: nothing to do! |
What does this PR do?
chore: CRW-4043 update rhel.Dockerfile and brew.Dockerfile so they're more closely aligned; update go.sum
Change-Id: Iaccd3d8f1e2b68f3f85db08635abcedccbb59e54
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4043
followed up by:
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.